-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add "Go to file", "Delete Directory" to repo file list page #35911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3452673 to
1cf0812
Compare
ca8791e to
457f17f
Compare
f169aa3 to
809a645
Compare
|
You can do so in the main repo page in the code tab, same as to how its done on Github. Since I'm not aware of a way to view the root directory except for in the main repo page on the code tab (same on Github). Or perhaps I'm not understanding what you mean. |
809a645 to
0adcc74
Compare
4540d07 to
57782c3
Compare
Fixed
Moved. Should be more like Github's UX now: Screen.Recording.2025-11-13.at.14.04.46.mov |
|
Thanks for addressing the issues you brought up. Looks like you've beat me to most of it. 😅 |
|
Fixed more problems:
|
|
Found new problems, for example, if you navigate the tree item from the "editor" page, then some styles become wrong. And the "go to file" input won't appear. Need to carefully check every change, but not just copy the "repo-view-container" code to other pages and assume that everything should work. |
|
Done from my side. Please help to test and review, feel free to merge if no more problem. |
By the way, I reverted this change. IMO:
|
|
Gone over the changes, retested all the functionality and updated the PR description to reflect recent changes. LGTM @wxiaoguang, thanks for having a look. |
|
Is it possible to add an approval to this now? @wxiaoguang |
wxiaoguang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
BTW: found a new bug: the blame page doesn't work with the "upload file" because some data is missing. Did a quick fix and leave some TODO comments.




/claim #35898
Resolves #35898
Summary of key changes:
Detailed breakdown:
1. Add search functionality to tree view
Added file search to repo view using existing search
filterRepoFilesWeighted, with new modal to display the search results. User can navigate through search results using keyboard to scroll, select and escape the search on top of using mouse. No matches found notice when no results are found. Replacing the existingFindFilespage.Screen.Recording.2025-11-30.at.05.37.00.mov
2. Add backend functionality to delete directory
Modified the
DeleteFilePostendpoint and related services to also allow for deletion of whole directories to support the "Delete directory" menu option added to the context menu.3. Add context menu for directories with functionality to copy permalink & delete a directory
Added context menu for "Copy Permalink" & "Delete directory" supported by backend change listed above.
Screen.Recording.2025-11-30.at.05.40.19.mov
4. Move Add/Upload file dropdown to right for parity with Github UI
Minor change to move this option to the right since already existed.
5. Add tree view to the edit/upload & patch UI